Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown Unirest workers #5054

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Shutdown Unirest workers #5054

merged 1 commit into from
Jun 14, 2019

Conversation

stefan-kolb
Copy link
Member

Just realized that our shutdown problems might also be caused by the Unirest library:

Exiting an application
Unirest starts a background event loop and your Java application won't be able to exit until you manually shutdown all the threads by invoking:
Unirest.shutdown();

Maybe worth a try?

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 13, 2019
Siedlerchr
Siedlerchr approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be useuful

@tobiasdiez tobiasdiez merged commit 47e3cc5 into master Jun 14, 2019
@tobiasdiez tobiasdiez deleted the unirest-shutdown branch June 14, 2019 07:42
github-actions bot pushed a commit to RamonG92/jabref that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
079b596 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (JabRef#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (JabRef#5052)
c74218d Update iso690-full-note-cs.csl (JabRef#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (JabRef#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (JabRef#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (JabRef#5050)
a0c044d Reindent/reorder (JabRef#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
6520cbf 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (JabRef#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (JabRef#5052)
c74218d Update iso690-full-note-cs.csl (JabRef#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (JabRef#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (JabRef#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (JabRef#5050)
a0c044d Reindent/reorder (JabRef#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
github-actions bot pushed a commit to Xuanxuan-Zou/jabref that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
608a6c7 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (JabRef#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (JabRef#5052)
c74218d Update iso690-full-note-cs.csl (JabRef#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (JabRef#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (JabRef#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (JabRef#5050)
a0c044d Reindent/reorder (JabRef#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
github-actions bot pushed a commit to dimitra-karadima/jabref that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
20ec838 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (JabRef#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (JabRef#5052)
c74218d Update iso690-full-note-cs.csl (JabRef#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (JabRef#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (JabRef#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (JabRef#5050)
a0c044d Reindent/reorder (JabRef#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
github-actions bot pushed a commit to felixbohnacker/jabref that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
982f489 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (JabRef#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (JabRef#5052)
c74218d Update iso690-full-note-cs.csl (JabRef#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (JabRef#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (JabRef#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (JabRef#5050)
a0c044d Reindent/reorder (JabRef#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
e337f93 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (JabRef#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (JabRef#5052)
c74218d Update iso690-full-note-cs.csl (JabRef#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (JabRef#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (JabRef#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (JabRef#5050)
a0c044d Reindent/reorder (JabRef#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
github-actions bot pushed a commit to eetian/jabref that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
9910738 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (JabRef#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (JabRef#5052)
c74218d Update iso690-full-note-cs.csl (JabRef#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (JabRef#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (JabRef#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (JabRef#5050)
a0c044d Reindent/reorder (JabRef#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
github-actions bot pushed a commit that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
84fcd5b 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (#5052)
c74218d Update iso690-full-note-cs.csl (#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (#5050)
a0c044d Reindent/reorder (#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
github-actions bot pushed a commit to dextep/jabref that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
4bc585b 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (JabRef#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (JabRef#5052)
c74218d Update iso690-full-note-cs.csl (JabRef#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (JabRef#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (JabRef#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (JabRef#5050)
a0c044d Reindent/reorder (JabRef#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
github-actions bot pushed a commit to graffaner/jabref that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
61946e6 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (JabRef#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (JabRef#5052)
c74218d Update iso690-full-note-cs.csl (JabRef#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (JabRef#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (JabRef#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (JabRef#5050)
a0c044d Reindent/reorder (JabRef#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
1058a20 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (JabRef#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (JabRef#5052)
c74218d Update iso690-full-note-cs.csl (JabRef#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (JabRef#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (JabRef#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (JabRef#5050)
a0c044d Reindent/reorder (JabRef#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
github-actions bot pushed a commit to joe9111/jabref that referenced this pull request Oct 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
28683e9 
5297abd Delete wirtschaftsuniversitat-wien-interdisziplinares-institut-fur-verhaltenswissenschaftlich-orientiertes-management.csl (JabRef#5023)
4b95fd1 New style - german-yearbook-of-international-law.csl (JabRef#5052)
c74218d Update iso690-full-note-cs.csl (JabRef#5062)
e72fb75 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#5058)
a440a12 Ann. Rev. Astron.: Remove form="short" for URL
325772c Create european-journal-of-theology.csl (JabRef#5055)
7643924 Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5022)
15e8a12 Update RCN-Harvard based on feedback
b9a37b7 Update harvard-university-of-westminster.csl (JabRef#5044)
7826be2 New version of the style for the History Department at the University of Lausanne (JabRef#5050)
a0c044d Reindent/reorder (JabRef#5054)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5297abd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefan-kolb @Siedlerchr @tobiasdiez